Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Import cefclient-2623 code and include it on Linux build only #584

Merged
merged 1 commit into from
Oct 4, 2016

Conversation

ficristo
Copy link
Collaborator

@ficristo ficristo commented Oct 2, 2016

Since it is too hard for me to update all 3 platforms, now I would like to try to run only Linux with the newer cefclient code.
I removed the tests and osr files and updated the imports, otherwise the code is a copy and paste.
Actually doesn't compile without #562.

@ficristo
Copy link
Collaborator Author

ficristo commented Oct 2, 2016

I forgot to say, since I'm looking on at Linux, I didn't import the code specific for the other platforms.

@ficristo ficristo changed the title Import cefclient-2623 code and compile it only on Linux Import cefclient-2623 code and include it on Linux build only Oct 4, 2016
@ficristo
Copy link
Collaborator Author

ficristo commented Oct 4, 2016

I noticed some references to test_runner which is define in a file not included: I've removed or commented them.

To be correct, I still cannot compile on Linux, but at least it doesn't introduce more errors.

The only change here is I've renamed appshell/cefclient_gtk.cppappshell/cefclient_gtk.cc (notice the extension) to match the cefclient example code

I could include all these files on other platforms but on Windows I had some problems compiling files with same name (appshell/client_app.h and appshell/common/client_app.h for example)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant