This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Move resource(_util*) under a new browser folder #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ingorichter Can you try building/running this one on your Mac, too? Btw, everything's fine here on my Windows 10 machine, VS 2012 Express. |
|
LGTM. It's builds just fine on OSX 10.11.6 with xcode 7.3.1. |
|
@ficristo I assume you compiled on Linux? |
|
@ingorichter unfortunately I still cannot compile master on Linux. I hope to at least get there soon. |
|
Looks good to me. Good work! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another cleanup to match more the cefclient.
Build on Windows 10 with VS2015u3