Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Fix crash on quit in CEF 2171 linux #503

Closed
wants to merge 3 commits into from
Closed

Fix crash on quit in CEF 2171 linux #503

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ed7a6b3
Quit Fix
nathanial Jun 25, 2014
c8afcbc
Merge remote-tracking branch 'origin/pr/458' into jasonsanjose/cef_21…
jasonsanjose Feb 10, 2015
66d826d
update CloseWindow fix for CEF 2171. thanks @nathanial
jasonsanjose Feb 10, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions appshell/appshell_extensions_gtk.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,23 +537,10 @@ void CloseWindow(CefRefPtr<CefBrowser> browser)
{
if (browser.get()) {
isReallyClosing = true;
browser->GetHost()->CloseBrowser(true);

// //# Hack because CEF's CloseBrowser() is bad. Should emit delete_event instead of directly destroying widget
//GtkWidget* hwnd = gtk_widget_get_toplevel (browser->GetHost()->GetWindowHandle() );
//GtkWindow* hwnd = GTK_WINDOW(gtk_widget_get_toplevel(GTK_WIDGET(g_handler->GetMainHwnd())));
// if(gtk_widget_is_toplevel (hwnd))
//g_message("Called destroy");
//gtk_widget_destroy(gtk_widget_get_toplevel(GTK_WIDGET(g_handler->GetMainHwnd())));
//gtk_signal_emit_by_name(GTK_OBJECT(hwnd), "delete_event");
// else

// pass this message onto the window
if (g_handler && g_handler->GetMainHwnd()) {
GtkWidget* hwnd = gtk_widget_get_toplevel(GTK_WIDGET(g_handler->GetMainHwnd()));
if(gtk_widget_is_toplevel (hwnd))
gtk_signal_emit_by_name(GTK_OBJECT(hwnd), "delete_event");
}
GtkWidget* hwnd = gtk_widget_get_toplevel (GTK_WIDGET(g_handler->GetMainHwnd() ));
browser->GetHost()->CloseBrowser(true);
gtk_signal_emit_by_name(GTK_OBJECT(hwnd), "delete_event");
}
}

Expand Down