Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asset Rendition dispatcher tracking hook #958

Merged
merged 2 commits into from
Jun 15, 2023

Conversation

davidjgonzalez
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jun 14, 2023

Codecov Report

Merging #958 (5138d2c) into develop (1910779) will decrease coverage by 0.10%.
The diff coverage is 10.34%.

@@              Coverage Diff              @@
##             develop     #958      +/-   ##
=============================================
- Coverage      27.34%   27.24%   -0.10%     
+ Complexity       500      497       -3     
=============================================
  Files            171      171              
  Lines           4344     4367      +23     
  Branches         611      620       +9     
=============================================
+ Hits            1188     1190       +2     
- Misses          2988     3007      +19     
- Partials         168      170       +2     
Flag Coverage Δ
unittests 27.24% <10.34%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...sync/impl/AsyncAssetRenditionsDownloadServlet.java 4.16% <0.00%> (-0.06%) ⬇️
...nc/impl/NamedRenditionDownloadTargetProcessor.java 0.00% <0.00%> (ø)
...patchers/AssetDeliveryRenditionDispatcherImpl.java 0.00% <0.00%> (ø)
...chers/ExternalRedirectRenditionDispatcherImpl.java 40.81% <0.00%> (-3.63%) ⬇️
...chers/InternalRedirectRenditionDispatcherImpl.java 62.22% <0.00%> (-2.90%) ⬇️
...mpl/dispatchers/StaticRenditionDispatcherImpl.java 58.82% <0.00%> (-5.76%) ⬇️
...e/content/renditions/AssetRenditionParameters.java 71.15% <25.00%> (-3.85%) ⬇️
...tions/download/async/DownloadTargetParameters.java 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidjgonzalez davidjgonzalez added this to the 3.1.0 milestone Jun 15, 2023
@davidjgonzalez davidjgonzalez merged commit 2815193 into adobe:develop Jun 15, 2023
@davidjgonzalez davidjgonzalez deleted the tracking branch June 15, 2023 16:13
@davidjgonzalez davidjgonzalez modified the milestones: 3.1.0, 3.2.0 Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant