Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some data-sly-test to data-sly-set and moved data-sly-use of … #926

Merged
merged 2 commits into from
Apr 24, 2023

Conversation

davidjgonzalez
Copy link
Contributor

…templates to the top to prevent them from going null

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…templates to the top to prevent them from going null
@davidjgonzalez davidjgonzalez marked this pull request as draft April 24, 2023 18:59
@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #926 (748e4b2) into develop (75578f4) will not change coverage.
The diff coverage is n/a.

❗ Current head 748e4b2 differs from pull request most recent head c61ae40. Consider uploading reports for the commit c61ae40 to get more accurate results

@@            Coverage Diff             @@
##             develop     #926   +/-   ##
==========================================
  Coverage      28.04%   28.04%           
  Complexity       499      499           
==========================================
  Files            170      170           
  Lines           4207     4207           
  Branches         584      584           
==========================================
  Hits            1180     1180           
  Misses          2865     2865           
  Partials         162      162           
Flag Coverage Δ
unittests 28.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@davidjgonzalez davidjgonzalez marked this pull request as ready for review April 24, 2023 19:28
@davidjgonzalez davidjgonzalez merged commit f39c807 into adobe:develop Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant