Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#737 - PMD fixes #762

Merged
merged 3 commits into from
Jun 27, 2022
Merged

#737 - PMD fixes #762

merged 3 commits into from
Jun 27, 2022

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Jun 27, 2022

Contains PMD fixed identified during the analysis profile executing of the project. These fixes are:

  1. Putting guards around log statements
  2. Correcting number of parameters to log statements
  3. Collapsing if clauses

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@kwin
Copy link
Collaborator

kwin commented Jun 27, 2022

If PMD checks are mandatory please enable the analysis profile by default (both for CI with GitHub Actions and for local Maven builds), at the same time the other profile analysisCI can probably be removed

@davidjgonzalez
Copy link
Contributor Author

@kwin this is in preparation to support the analysis profile. There are further issues as well in that profile that i need to resolve, but haven't gotten to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants