Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issues (that have fixes) identified by AEM Analyse 1.6.6 #1225

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Jan 31, 2025

Removed use of Google Guava Collections and the org.apache.common uses I could (cannot replace StrLookup)

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 44.92754% with 38 lines in your changes missing coverage. Please review.

Project coverage is 27.88%. Comparing base (e5c4d0e) to head (98a7877).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
.../components/predicates/impl/PagePredicateImpl.java 0.00% 33 Missing ⚠️
.../assetkit/impl/AssetKitCreatorWorkflowProcess.java 0.00% 3 Missing ⚠️
...setshare/components/actions/download/Download.java 0.00% 1 Missing ⚠️
...teevaluators/PropertyValuesPredicateEvaluator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1225      +/-   ##
=============================================
- Coverage      27.99%   27.88%   -0.12%     
  Complexity       553      553              
=============================================
  Files            182      182              
  Lines           4769     4788      +19     
  Branches         679      681       +2     
=============================================
  Hits            1335     1335              
- Misses          3245     3264      +19     
  Partials         189      189              
Flag Coverage Δ
unittests 27.88% <44.92%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit 3974c3b into adobe:develop Jan 31, 2025
5 of 6 checks passed
@davidjgonzalez davidjgonzalez deleted the deprecated-apis branch January 31, 2025 18:23
@davidjgonzalez davidjgonzalez self-assigned this Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant