Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with Initial values #1218

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Jan 24, 2025

Fixes #1215

Description

Issue with predicate group assignmnent. This was because the isReady() check in initGroup relied on the group Id making a cyclical-ish condition. Removed the isReady check in initGroup.. the only downside is groupId may not always be sequential (if there's a !isReady predicate between two "ready" predicates) however this doesnt have any material impact.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez added this to the 3.9.0 milestone Jan 24, 2025
Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 27.99%. Comparing base (3ed3d6b) to head (c4b6e1a).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...share/components/predicates/AbstractPredicate.java 0.00% 19 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1218      +/-   ##
=============================================
- Coverage      27.99%   27.99%   -0.01%     
- Complexity       552      553       +1     
=============================================
  Files            182      182              
  Lines           4772     4769       -3     
  Branches         680      679       -1     
=============================================
- Hits            1336     1335       -1     
+ Misses          3246     3245       -1     
+ Partials         190      189       -1     
Flag Coverage Δ
unittests 27.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit e5c4d0e into adobe:develop Jan 24, 2025
4 of 6 checks passed
@davidjgonzalez davidjgonzalez self-assigned this Jan 24, 2025
@davidjgonzalez davidjgonzalez deleted the initial-values branch January 24, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filters in the sidebar isn't opened after URL is copied into new tab (causes also other issues)
1 participant