Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding share tracking #1210

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Adding share tracking #1210

merged 2 commits into from
Jan 24, 2025

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Dec 11, 2024

Add tracking to Email share component.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 27.93%. Comparing base (d29cbf7) to head (aa7c917).
Report is 35 commits behind head on develop.

Files with missing lines Patch % Lines
...ents/actions/share/impl/EmailShareServiceImpl.java 0.00% 11 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #1210      +/-   ##
=============================================
- Coverage      28.19%   27.93%   -0.26%     
  Complexity       552      552              
=============================================
  Files            182      182              
  Lines           4738     4782      +44     
  Branches         673      682       +9     
=============================================
  Hits            1336     1336              
- Misses          3213     3256      +43     
- Partials         189      190       +1     
Flag Coverage Δ
unittests 27.93% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/pom.xml Outdated Show resolved Hide resolved
@davidjgonzalez davidjgonzalez added this to the 3.9.0 milestone Jan 24, 2025
@davidjgonzalez davidjgonzalez merged commit 6a21e82 into adobe:develop Jan 24, 2025
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant