Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js.txt to import moment-with-locales.min.js #1176 #1177

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

zhgeric
Copy link
Contributor

@zhgeric zhgeric commented Sep 13, 2024

Update js.txt to import moment-with-locales.min.js

Description

I saw that moment-with-locales.min.js script was present but not used

Related Issue

#1176

Motivation and Context

Enable automatic translation for Metadata components when using datetime related metadata

How Has This Been Tested?

I changed this file on my locale environmment and it worked

Screenshots (if appropriate):

Before
image
After
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.19%. Comparing base (64747ab) to head (eeb07a7).
Report is 23 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1177   +/-   ##
==========================================
  Coverage      28.19%   28.19%           
  Complexity       552      552           
==========================================
  Files            182      182           
  Lines           4738     4738           
  Branches         673      673           
==========================================
  Hits            1336     1336           
  Misses          3213     3213           
  Partials         189      189           
Flag Coverage Δ
unittests 28.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidjgonzalez davidjgonzalez merged commit cbe15cf into adobe:develop Sep 13, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants