Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #1132 Update jQuery version to 3.5.1 in vendor #1133

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

zhgeric
Copy link
Contributor

@zhgeric zhgeric commented May 31, 2024

Description

I changed the jQuery 3.4.1 file to jQuery 3.5.1 file

Related Issue

Update jQuery version to 3.5.1 in vendor #1132

Motivation and Context

Update the version of jQuery used when using asset-share-commons dependancy in aem
I need an updated version jquery to correct some vulnerabilities

How Has This Been Tested?

I ran
mvn clean install -PautoInstallSinglePackage
and it got uploaded to aem

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the [Adobe Open Source CLA] (https://opensource.adobe.com/cla.html).
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhgeric
Copy link
Contributor Author

zhgeric commented May 31, 2024

Will this be applied to asset-share-commons version 3.7.0 and higher or do I need to make a PR for each version ?

@davidjgonzalez
Copy link
Contributor

This will be applied to the 3.8.6 and subsequent releases. Just 1 PR is good!👍

@zhgeric
Copy link
Contributor Author

zhgeric commented Jun 2, 2024

Ok thanks ! It's my 1st PR so I don't know how that works, do I only have to wait now ?

@davidjgonzalez davidjgonzalez merged commit ba99114 into adobe:develop Jun 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants