Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Feature: Nested Path/Tag Filters #1071

Closed
wants to merge 2 commits into from
Closed

Conversation

mfyobst
Copy link

@mfyobst mfyobst commented Jan 4, 2024

-nested-filters preview

Adds recursive cq:Tag and sling:Folder checkbox filters. Adds AbstractNestedPredicate/NestedOptionItem for future implementation.

Description

Added ui.apps/src/main/content/jcr_root/apps/asset-share-commons/components/search:

nested-path/
-includes clientlibs/site/js with vanilla js for checkbox management
-includes clientlibs/site/css with vanilla css for .nested.accordion, .nested.content

nested-tag/
-resourceSuperType="asset-share-commons/components/search/nested-path"

Added com.adobe.aem.commons.assetshare.components.predicates:
AbstractNestedPredicate
-includes base implementation; bulk of new code

NestedPathPredicate/NestedTagPredicate extends NestedPredicate
-interface for UI controls

NestedPathPredicateImpl/NestedTagPredicateImpl extends AbstractNestedPredicate
-override base as needed

NestedOptionItem implements OptionItem
-featherweight text/value OptionItem
-adds List children
-plus some convenience methods

No existing code was changed.

Related Issue

-dispatcher/pom.xml checksum compatibility fix
--for windows build issue: replaced requireFileChecksum>requireTextFileChecksum

Unrelated Issue

-tags.html removed orphaned
--may breaks site layout under certain conditions

How Has This Been Tested?

Only tested manually
-Testing integration tbd.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Max Yobst added 2 commits January 4, 2024 10:30
-dispatcher/pom.xml checksum compatibility fix
-tags.html removed orphaned </sly>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants