Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property filter's Datasource option breaks page's HTML #1129

Closed
davidjgonzalez opened this issue May 20, 2024 · 1 comment
Closed

Property filter's Datasource option breaks page's HTML #1129

davidjgonzalez opened this issue May 20, 2024 · 1 comment
Labels
Milestone

Comments

@davidjgonzalez
Copy link
Contributor

Describe the bug

When selecting the DataSource option from Property Filter, the search page's HTML breaks.

I believe this has something to do the reliance on the AEM WCM Core Components Options implementation to back these options. It seems like when the WCM Core Components OptionsImpl collects the data source, it performs an internal request.include to the property filter resource, which generates a blank rendition of the Property Filter component (or whatever component that might be).

https://github.com/adobe/aem-core-wcm-components/blob/main/bundles/core/src/main/java/com/adobe/cq/wcm/core/components/internal/models/v1/form/OptionsImpl.java#L208

Environment

  • AEM Version: 2024.2.15262.20240224T002940Z-231200
  • Asset Share Commons Version: 3.8.6
  • Author, Publish or both? Bother

To Reproduce

Configure the demo Property Filter to be run from datasource asset-share-commons/data-sources/computed-properties and watch the page break. Flip it back to JSON or Local and the page does no break (no incorrect HTML in in source).

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

davidjgonzalez added a commit to davidjgonzalez/asset-share-commons that referenced this issue May 20, 2024
davidjgonzalez added a commit that referenced this issue Jun 3, 2024
Fix for #1129 - Property Filter datasource option breaks search page …
@davidjgonzalez davidjgonzalez added this to the 3.8.10 milestone Jul 8, 2024
@davidjgonzalez
Copy link
Contributor Author

Fixed in 3.8.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant