#569 - Removed usage of Class.forName(...) in ModelCacheImpl

adobe · Feb 25, 2021 · 613a640 · 613a640
1 parent 8d72ecb
commit 613a640
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -29,4 +29,7 @@ content/src/main/content/jcr_root/etc/.content.xml
 content/src/main/content/jcr_root/etc/designs/.content.xml
 content/src/main/content/jcr_root/etc/clientlibs/.content.xml
 
-ui.tests/node_modules/
+ui.tests/node_modules/
+
+#VS Code
+.history
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,11 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
-## [Unrelease]
+## [Unreleased]
 
 ### Changed
 
 - 0531: Release to maven central (instead of bintray)
+- 0596: Updated ModelCacheImpl to use the DynamicClassLoaderManager.getDynamicClassLoader().loadClass(...) rather than Class.forName(..) 
 
 ### Fixed 
 

diff --git a/core/src/main/java/com/adobe/aem/commons/assetshare/util/impl/ModelCacheImpl.java b/core/src/main/java/com/adobe/aem/commons/assetshare/util/impl/ModelCacheImpl.java
@@ -37,7 +37,7 @@ public final Object get(Object key) {
         Class clazz = null;
 
         try {
-            clazz = Class.forName((String) key, true, dynamicClassLoaderManager.getDynamicClassLoader());
+            clazz = dynamicClassLoaderManager.getDynamicClassLoader().loadClass((String) key);
             return get(clazz);
         } catch (ClassNotFoundException e) {
             throw new IllegalArgumentException("Unable to derive a class from " + (String)key);