Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Feign Header Processing #77

Merged
merged 3 commits into from
Jun 2, 2022

Conversation

bstopp
Copy link
Collaborator

@bstopp bstopp commented Mar 25, 2022

Extract API Key header to separate AIO Request Interceptor.

So that can add the x-gw-ims-org-id header to requests .

@francoisledroff
Copy link
Collaborator

Thanks @bstopp could you shade some light on the motivation here ?
x-gw-ims-org-id is added by the Adobe API gateway

@bstopp
Copy link
Collaborator Author

bstopp commented Mar 28, 2022

My understanding is that this header is required to make API calls:

It's not added by the gateway - it's required by the gateway.

@francoisledroff
Copy link
Collaborator

I see, thanks !
I'll review this further asap.

@bstopp
Copy link
Collaborator Author

bstopp commented May 31, 2022

Any update on this? I'm making updates to the aio-lib-java-cloudmanager library, which depends on this change.

@francoisledroff francoisledroff merged commit 2cf2a7b into adobe:main Jun 2, 2022
@francoisledroff
Copy link
Collaborator

Looking good, I gave it a test and merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants