GH-52 Add com.adobe.aio.aem.event.management a Java OSGI bundle hosting OSGI Components wrapping aio-lib-java-events-mgmt #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgera
reviewed
Mar 23, 2022
| * AEM has to register against Adobe I/O Events API management, in order to be assigned a | ||
| * providerId, and then to be able to register its event metadata | ||
| */ | ||
| public interface EventProviderRegistrationService extends StatusSupplier { |
There was a problem hiding this comment.
@francoisledroff Shouldn't the AEM OSGI bundle transparently map the same interface as our core java SDK?
For example, in this interface we cherry-picked only these two methods getRegisteredProvider and registerEventMetadata. Any reason for not implementing ALL the methods that we have in ProviderService and RegistrationService in two separate OSGI interfaces?
There was a problem hiding this comment.
All AEM interfaces have a subset of methods. For instance, in EventPublishService also, we have one method out of many present in PublishService
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.