Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-30 adding a createOrUpdateProvider() method to the ProviderService #31

Merged
merged 4 commits into from
Oct 1, 2021

Conversation

francoisledroff
Copy link
Collaborator

#30 adding a createOrUpdateProvider() method to the ProviderService

@amol-anand
Copy link
Contributor

If I can create or update a provider based on a user/system generated ID and not worry about ProviderId that gets returned, then I would also need to be able to find a provider based on the user/system generated ID. In this case "instanceId"

Assuming I can create / update a provider and pass "instanceId" = "amol"; i should also be able to findProviderByInstanceId("amol") and get the providerId needed for things like consuming events and registering journals etc.. That way I never have to save the providerId and I only need to worry about instanceId. What would also be great is if we were able to register a journal listening to events based on the instanceId and not ProviderId too.

@francoisledroff
Copy link
Collaborator Author

@amol-anand thanks for your feedback I added a findCustomEventsProviderByInstanceId method to the ProviderService

…yInstanceId` method to the `ProviderService`
@francoisledroff francoisledroff merged commit dd362e9 into adobe:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants