-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-26 adding osgi
: an osgi bundle to ease the use of these sdk jars within AEM
#29
Conversation
osgi
: an osgi bundle to ease the use of these sdk jars within AEM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added minor comments.
osgi/pom.xml
Outdated
<configuration> | ||
<instructions> | ||
<_noee>true</_noee> | ||
<!-- <Bundle-Activator>com.adobe.aio.lib.Activator</Bundle-Activator> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be uncommented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
@@ -27,6 +27,7 @@ | |||
<module>events_mgmt</module> | |||
<module>events_ingress</module> | |||
<module>events_journal</module> | |||
<module>osgi</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to add this module to the README.md
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
adding an osgi bundle to ease the use of these sdk jars within AEM