Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-26 adding osgi: an osgi bundle to ease the use of these sdk jars within AEM #29

Merged
merged 10 commits into from
Sep 29, 2021

Conversation

francoisledroff
Copy link
Collaborator

adding an osgi bundle to ease the use of these sdk jars within AEM

@francoisledroff francoisledroff changed the title GH-26 adding an osgi bundle to ease the use of these sdk jars within AEM GH-26 adding osgi: an osgi bundle to ease the use of these sdk jars within AEM Sep 27, 2021
Copy link
Member

@shikhartanwar shikhartanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added minor comments.

osgi/pom.xml Outdated
<configuration>
<instructions>
<_noee>true</_noee>
<!-- <Bundle-Activator>com.adobe.aio.lib.Activator</Bundle-Activator> -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be uncommented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@@ -27,6 +27,7 @@
<module>events_mgmt</module>
<module>events_ingress</module>
<module>events_journal</module>
<module>osgi</module>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add this module to the README.md as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Member

@shikhartanwar shikhartanwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francoisledroff francoisledroff merged commit e2c5201 into adobe:main Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants