Issue 24 - Method to add multiple EventsOfInterest to the model #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need this for someone who wants to register multiple combinations of Provider ID and Event Code to one Journal/Webhook.
|
@francoisledroff please review and merge. need a way to add multiple combos of ProviderId and EventCode while registering a new journal to listen to events. |
| @@ -157,6 +157,12 @@ public Builder addEventsOfInterests( | |||
| return this; | |||
| } | |||
|
|
|||
| public Builder addMultipleEventsOfInterests( | |||
There was a problem hiding this comment.
wdyt just reusing the same method name addEventsOfInterests here ?
There was a problem hiding this comment.
makes sense considering the method name is plural and intended for that purpose. ill update the PR
this way you could send either one EventsOfInterest or a Set of EventsOfInterest
|
@francoisledroff updated. please review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Need this for someone who wants to register multiple combinations of Provider ID and Event Code to one Journal/Webhook.
Related Issue
#24
Motivation and Context
Need this for someone who wants to register multiple combinations of Provider ID and Event Code to one Journal/Webhook.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: