-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-221 wiring the new x-event-phidata
header support in Adobe IO Events eventsingress
PublishApi
#222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents `eventsingress` `PublishApi`
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 09:47 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_prod
June 24, 2024 09:47 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 09:55 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 10:07 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 10:12 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 10:15 — with
GitHub Actions
Failure
francoisledroff
had a problem deploying
to
aio_stage
June 24, 2024 10:33 — with
GitHub Actions
Failure
nicdard
reviewed
Jun 24, 2024
@@ -57,8 +57,8 @@ public class FeignUtil { | |||
public static final String AIO_FEIGN_RETRY_MAX_PERIOD = "AIO_FEIGN_RETRY_MAX_PERIOD"; | |||
|
|||
|
|||
private static final int DEFAULT_CONNECT_TIMEOUT_IN_SECONDS = 10; | |||
private static final int DEFAULT_READ_TIMEOUT_IN_SECONDS = 60; | |||
public static final int DEFAULT_CONNECT_TIMEOUT_IN_SECONDS = 10; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
nicdard
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
francoisledroff
temporarily deployed
to
aio_stage
June 24, 2024 15:21 — with
GitHub Actions
Inactive
shikhartanwar
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GH-221 wiring the new
x-event-phidata
header support in Adobe IO Eventseventsingress
PublishApi