Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-210: fixed scope parameter issue #211

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

pulguptaAdobe
Copy link
Contributor

@pulguptaAdobe pulguptaAdobe commented Jan 26, 2024

Description

All operations which needs a token are failing when using OAuth based workspace

Related Issue

Motivation and Context

In the actual API call parameter-name is scope but sdk is using scopes

Sample Curl call

curl -X POST 'https://ims-na1-stg1.adobelogin.com/ims/token/v3' -H 'Content-Type: application/x-www-form-urlencoded' -d 'grant_type=client_credentials&client_id=xxxxx&client_secret=xxxxxx&scope=yyyy,zzzzz'

How Has This Been Tested?

I deployed the local build on AEM cloud and tested & the fix is working fine.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@pulguptaAdobe pulguptaAdobe changed the title fixed scope parameter issue GH-210: fixed scope parameter issue Jan 26, 2024
@francoisledroff francoisledroff changed the base branch from main to GH-210 January 29, 2024 10:03
@francoisledroff francoisledroff merged commit 1debf09 into adobe:GH-210 Jan 29, 2024
3 of 5 checks passed
francoisledroff added a commit that referenced this pull request Jan 29, 2024
…ken/v3` (#211) (#212)

Co-authored-by: Pulkit Gupta <92841386+pulguptaAdobe@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants