Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing the runtime registration create assertion #191

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fixing the runtime registration create assertion #191

merged 1 commit into from
Oct 16, 2023

Conversation

abhupadh
Copy link
Collaborator

@abhupadh abhupadh commented Oct 13, 2023 •
edited
Loading

Description

GH-188 a fix for runtime registration create assertion failure on webhook url.

Related Issue

Motivation and Context

Helps assert successfully for the created runtime webhook registration

How Has This Been Tested?

Using runtime e2e test via aio_events_itests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@abhupadh abhupadh temporarily deployed to aio_stage October 13, 2023 23:47 — with GitHub Actions Inactive
@abhupadh abhupadh temporarily deployed to aio_prod October 13, 2023 23:47 — with GitHub Actions Inactive
francoisledroff
francoisledroff reviewed Oct 16, 2023
View reviewed changes
events_test/src/main/java/com/adobe/aio/event/management/RegistrationServiceTester.java
}
} else {
assertNull(registration.get().getWebhookUrl());
assertUrl(registration.get().getJournalUrl().getHref());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this assertion is already here on line 105/114

@francoisledroff francoisledroff merged commit 73b384c into main Oct 16, 2023
@abhupadh abhupadh mentioned this pull request Oct 20, 2023
Closed
@shikhartanwar shikhartanwar deleted the GH-188-Patch branch September 16, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisledroff francoisledroff francoisledroff left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhupadh @francoisledroff