`GH-188` `events_mgmt` adding support for Adobe `Runtime` Actions as webhooks #187

abhupadh · 2023-10-10T23:55:04Z

Description

Adding support for managing runtime webhook registrations

Related Issue

events_mgmt add support for Adobe Runtime Actions as webhooks #188

Motivation and Context

To enable integration testing for runtime webhook registrations.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

I have signed the Adobe Open Source CLA.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.

francoisledroff

a few first comments

core/src/main/java/com/adobe/aio/util/Constants.java

events_test/src/main/java/com/adobe/aio/event/publish/PublishServiceTester.java

francoisledroff

a few requests:

core/src/main/java/com/adobe/aio/workspace/Workspace.java

events_test/src/test/java/com/adobe/aio/event/util/DataNodeUtil.java

francoisledroff

I'll propose some cleanup in my own PR

events_mgmt/src/main/java/com/adobe/aio/event/management/model/RegistrationUpdateModel.java

nicdard · 2023-10-13T08:30:48Z

events_mgmt/src/main/java/com/adobe/aio/event/management/model/RegistrationUpdateModel.java

@@ -58,11 +61,16 @@ public class RegistrationUpdateModel {
    this.webhookUrl = webhookUrl;
    this.eventsOfInterestInputModels = eventsOfInterestInputModels;
    if (DeliveryType.fromFriendlyName(deliveryType).isWebhookDelivery() && StringUtils.isEmpty(webhookUrl)) {
-      throw new IllegalArgumentException(
-                      "Registration is a webhook registration, but missing a webhook url");
+      if (StringUtils.isNotEmpty(runtimeAction)) {


Can we move this condition inside the enclosing if by adding && StringUtils.isEmpty(runtimeAction)?

events_test/src/main/java/com/adobe/aio/event/management/RegistrationServiceTester.java

events_mgmt/src/main/java/com/adobe/aio/event/management/model/Event.java

francoisledroff · 2023-10-13T09:41:50Z

I pushed some cleanup against your branch see #189

…elease in this open-source sdk (#189) GH-188 code cleanup * removing the complexity/code we don't want to release in this open-source sdk * plus adding a bit of doc on the new OAuth support

nicdard

LGTM

feat: adding support for runtime webhook registrations

400fdc2

abhupadh had a problem deploying to aio_prod October 10, 2023 23:55 — with GitHub Actions Failure

abhupadh had a problem deploying to aio_stage October 10, 2023 23:55 — with GitHub Actions Failure

adding license header to a new file Event.java

656b2b4

abhupadh had a problem deploying to aio_prod October 10, 2023 23:57 — with GitHub Actions Failure

abhupadh had a problem deploying to aio_stage October 10, 2023 23:57 — with GitHub Actions Failure

reverting package refactoring for EventVerifier

6b3e1a2

abhupadh temporarily deployed to aio_stage October 11, 2023 00:50 — with GitHub Actions Inactive

abhupadh temporarily deployed to aio_prod October 11, 2023 00:50 — with GitHub Actions Inactive

francoisledroff requested changes Oct 12, 2023

View reviewed changes

core/src/main/java/com/adobe/aio/util/Constants.java Outdated Show resolved Hide resolved

events_test/src/main/java/com/adobe/aio/event/publish/PublishServiceTester.java Outdated Show resolved Hide resolved

francoisledroff changed the title ~~feat: adding support for runtime webhook registrations~~ GH-128 adding support for runtime webhook registrations Oct 12, 2023

francoisledroff changed the title ~~GH-128 adding support for runtime webhook registrations~~ GH-128 adding support for runtime webhook registrations Oct 12, 2023

francoisledroff changed the title ~~GH-128 adding support for runtime webhook registrations~~ GH-188 events_mgmt adding support for Adobe Runtime Actions as webhooks Oct 12, 2023

francoisledroff reviewed Oct 12, 2023

View reviewed changes

events_test/src/main/java/com/adobe/aio/event/publish/PublishServiceTester.java Show resolved Hide resolved

refactoring of publish cloud event method, removing unused constants

3ae1fb4

abhupadh temporarily deployed to aio_stage October 12, 2023 19:33 — with GitHub Actions Inactive

abhupadh temporarily deployed to aio_prod October 12, 2023 19:33 — with GitHub Actions Inactive

removing unused imports

2a50bfc

abhupadh temporarily deployed to aio_stage October 12, 2023 19:43 — with GitHub Actions Inactive

abhupadh temporarily deployed to aio_prod October 12, 2023 19:43 — with GitHub Actions Inactive

francoisledroff requested changes Oct 12, 2023

View reviewed changes

core/src/main/java/com/adobe/aio/workspace/Workspace.java Outdated Show resolved Hide resolved

events_test/src/test/java/com/adobe/aio/event/util/DataNodeUtil.java Outdated Show resolved Hide resolved

removing runtime action from Workspace context

4a32b62

abhupadh temporarily deployed to aio_stage October 12, 2023 20:41 — with GitHub Actions Inactive

abhupadh temporarily deployed to aio_prod October 12, 2023 20:41 — with GitHub Actions Inactive

francoisledroff previously approved these changes Oct 13, 2023

View reviewed changes

nicdard reviewed Oct 13, 2023

View reviewed changes

events_mgmt/src/main/java/com/adobe/aio/event/management/model/RegistrationUpdateModel.java Outdated Show resolved Hide resolved

nicdard reviewed Oct 13, 2023

View reviewed changes

events_test/src/main/java/com/adobe/aio/event/management/RegistrationServiceTester.java Outdated Show resolved Hide resolved

francoisledroff reviewed Oct 13, 2023

View reviewed changes

events_mgmt/src/main/java/com/adobe/aio/event/management/model/Event.java Outdated Show resolved Hide resolved

GH-188 code cleanup - removing the complexity/code we don't want to r…

007ae99

…elease in this open-source sdk (#189) GH-188 code cleanup * removing the complexity/code we don't want to release in this open-source sdk * plus adding a bit of doc on the new OAuth support

francoisledroff dismissed their stale review via 007ae99 October 13, 2023 14:00

francoisledroff temporarily deployed to aio_stage October 13, 2023 14:00 — with GitHub Actions Inactive

francoisledroff temporarily deployed to aio_prod October 13, 2023 14:00 — with GitHub Actions Inactive

nicdard previously approved these changes Oct 13, 2023

View reviewed changes

GH-188 code cleanup - one left over unused constant

3ecb911

francoisledroff dismissed nicdard’s stale review via 3ecb911 October 13, 2023 14:14

francoisledroff temporarily deployed to aio_prod October 13, 2023 14:14 — with GitHub Actions Inactive

francoisledroff temporarily deployed to aio_stage October 13, 2023 14:14 — with GitHub Actions Inactive

nicdard approved these changes Oct 13, 2023

View reviewed changes

francoisledroff approved these changes Oct 13, 2023

View reviewed changes

francoisledroff merged commit e6a3358 into main Oct 13, 2023

nicdard deleted the abhupadh-runtime-webhook-test branch October 13, 2023 18:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`GH-188` `events_mgmt` adding support for Adobe `Runtime` Actions as webhooks #187

`GH-188` `events_mgmt` adding support for Adobe `Runtime` Actions as webhooks #187

abhupadh commented Oct 10, 2023 •

edited by francoisledroff

Loading

francoisledroff left a comment

francoisledroff left a comment

francoisledroff left a comment

nicdard Oct 13, 2023

francoisledroff commented Oct 13, 2023

nicdard left a comment

GH-188 events_mgmt adding support for Adobe Runtime Actions as webhooks #187

GH-188 events_mgmt adding support for Adobe Runtime Actions as webhooks #187

Conversation

abhupadh commented Oct 10, 2023 • edited by francoisledroff Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

francoisledroff left a comment

Choose a reason for hiding this comment

francoisledroff left a comment

Choose a reason for hiding this comment

francoisledroff left a comment

Choose a reason for hiding this comment

nicdard Oct 13, 2023

Choose a reason for hiding this comment

francoisledroff commented Oct 13, 2023

nicdard left a comment

Choose a reason for hiding this comment

`GH-188` `events_mgmt` adding support for Adobe `Runtime` Actions as webhooks #187

`GH-188` `events_mgmt` adding support for Adobe `Runtime` Actions as webhooks #187

abhupadh commented Oct 10, 2023 •

edited by francoisledroff

Loading