Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-157: expose a timeout configurable pollJournalForEvents method #161

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

nicdard
Copy link
Collaborator

@nicdard nicdard commented Jun 19, 2023

Description

Adding a new overload for method pollJournalForEvents which accepts a timeout in millis as parameter, maintaining also the default 2 minutes method that was already implemented.

Related Issue

Solves: #157

Motivation and Context

To load test the application, we might require to enlarge the timeout to retrieve multiple events from the Journal.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@nicdard nicdard temporarily deployed to aio_prod June 19, 2023 12:27 — with GitHub Actions Inactive
@nicdard nicdard changed the title feat(GH-157): expose a timeout configurable pollJournalForEvents method GH-157: expose a timeout configurable pollJournalForEvents method Jun 19, 2023
@nicdard nicdard temporarily deployed to aio_stage June 19, 2023 13:02 — with GitHub Actions Inactive
@nicdard nicdard temporarily deployed to aio_prod June 19, 2023 13:02 — with GitHub Actions Inactive
@francoisledroff francoisledroff merged commit 740a219 into main Jun 19, 2023
@shikhartanwar shikhartanwar deleted the GH-157 branch September 16, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants