GH-13 Wrapping Adobe I/O Events Publishing API #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import java.util.UUID; | ||
| import org.apache.commons.lang3.StringUtils; | ||
|
|
||
| public class CloudEvent { |
There was a problem hiding this comment.
We can use the Cloud event java SDK instead. https://github.com/cloudevents/sdk-java
There was a problem hiding this comment.
yes I guess we could ... but that would require quite a bit of work
let me add this to the project backlog for now: #16
| String apiUrl = StringUtils.isEmpty(url) ? PublishApi.DEFAULT_URL : url; | ||
| if (authInterceptor == null) { | ||
| throw new IllegalArgumentException( | ||
| "RegistrationService is missing a authentication interceptor"); |
There was a problem hiding this comment.
should be publish service is missing ....
| */ | ||
| @RequestLine("POST ") | ||
| @Headers({"Content-Type: application/cloudevents+json"}) | ||
| void post(CloudEvent body); |
There was a problem hiding this comment.
maybe we can rename it to publish?
| * | ||
| * @param body your CloudEvent Input Model | ||
| */ | ||
| @RequestLine("POST ") |
There was a problem hiding this comment.
there is a space here. not sure if its intentional "POST"
There was a problem hiding this comment.
yes extra space was not harmful but not needed either
sangeetha5491
approved these changes
Jun 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added the Publish API wrapper service