feat: enhance Feign utility using resiliency4j retries #149
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, retries are implicitly enabled from Feign, using the
Default Retryer
and with a maximal number of attempts of 5.The code changes enable the use of resiliency4j retries:
RetryableException
onlyRetry-After
header information when available, in which case use the maximum between the time given from the two.Other approaches:
Retryer
interface and implement our custom logic (parameters are a bit different + in case of a negative interval from the header the default retryer doesn't wait)I think we might be good with just (1) if we do not need any other resiliency pattern, which involves only adding 1 line when creating the Feign builder:
Related Issue
#150
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: