Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aio-lib-java-ims Enhance WorkspaceUtil to also check in the environment variables before falling back to the files. #213

Closed
nicdard opened this issue Jan 31, 2024 · 1 comment
Closed

aio-lib-java-ims Enhance WorkspaceUtil to also check in the environment variables before falling back to the files. #213

nicdard opened this issue Jan 31, 2024 · 1 comment

Comments

@nicdard
Copy link
Collaborator

nicdard commented Jan 31, 2024

Expected Behaviour

The WorkspaceUtil#getSystemWorkspaceBuilder method should check for properties that are set in the environment variables. The precedence should be the following:

  • system properties
  • environment variables
  • property files

This will allow an easier way to pass overrides to the test command without the need to explicitly set those with -D option

Actual Behaviour

As of now, environment variables are not taken in consideration.
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Jan 31, 2024
@nicdard
adobeGH-213: enhance WorkspaceUtil to also search in evnrionment vari…
4d3d3ac 
…ables
@nicdard nicdard mentioned this issue Jan 31, 2024
Merged
9 tasks
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Jan 31, 2024
@nicdard
docs(adobeGH-213): add JavaDocs
cf036b0
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Jan 31, 2024
@nicdard
refactor(adobeGH-213): rename getSystemWorkspaceBuilder to getWorkspa…
2531fc9 
…ceBuilder
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Jan 31, 2024
@nicdard
refactor(adobeGH-213): rename getSystemWorkspaceBuilder to getWorkspa…
8f4162b 
…ceBuilder
@francoisledroff francoisledroff changed the title Enhance WorkspaceUtil to also check in the environment variables before falling back to the files. aio-lib-java-ims Enhance WorkspaceUtil to also check in the environment variables before falling back to the files. Feb 1, 2024
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Feb 1, 2024
@nicdard
feat(adobeGH-213): enhance getSystemProperty to also check environmen…
6031f26 
…t variables
nicdard added a commit to nicdard/aio-lib-java that referenced this issue Feb 1, 2024
@nicdard
feat(adobeGH-213): enhance getSystemProperty to also check environmen…
3f7f81a 
…t variables
francoisledroff pushed a commit that referenced this issue Feb 1, 2024
@nicdard
GH-213: enhance WorkspaceUtil to also search in envrionment variables (…
4a53673 
…#214)
@francoisledroff francoisledroff mentioned this issue Feb 1, 2024
Merged
9 tasks
francoisledroff added a commit that referenced this issue Feb 12, 2024
@francoisledroff @nicdard
GH-213: enhance WorkspaceUtil to also search in envrionment variables (…
64a0b34 
…#214) (#216)

Co-authored-by: Nicola Dardanis <nicdard@gmail.com>
@francoisledroff
Copy link
Collaborator

francoisledroff commented Jun 18, 2024 •
edited
Loading

I believe it was fixed with #216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@francoisledroff @nicdard