Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOTB Service-Based rewrite rules should be exported #86

Merged
merged 3 commits into from
Nov 23, 2021

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Nov 23, 2021

Export Page & ColumnControl service-based rewrite rules.

@bstopp bstopp added the enhancement New feature or request label Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #86 (7ef862c) into main (70ed2ed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main      #86   +/-   ##
=========================================
  Coverage     79.04%   79.04%           
  Complexity      427      427           
=========================================
  Files            34       34           
  Lines          1928     1928           
  Branches        355      355           
=========================================
  Hits           1524     1524           
  Misses          296      296           
  Partials        108      108           
Flag Coverage Δ
unittests 79.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rnize/component/rule/ColumnControlRewriteRule.java 59.42% <ø> (ø)
.../aem/modernize/structure/rule/PageRewriteRule.java 82.84% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70ed2ed...7ef862c. Read the comment docs.

@bstopp bstopp merged commit 27b352b into adobe:main Nov 23, 2021
@bstopp bstopp deleted the update/expose-rules branch November 23, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant