Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reorder on Delete #120

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Fix reorder on Delete #120

merged 2 commits into from
Jan 20, 2022

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Jan 20, 2022

Description

Check for the node to have been deleted before attempting to continue to order parent's children

Related Issue

Issue #119

How Has This Been Tested?

Manually tested.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bstopp bstopp added the bug Something isn't working label Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #120 (899deb9) into main (e140f36) will increase coverage by 0.01%.
The diff coverage is 90.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #120      +/-   ##
============================================
+ Coverage     79.21%   79.22%   +0.01%     
- Complexity      430      431       +1     
============================================
  Files            34       34              
  Lines          1934     1935       +1     
  Branches        356      357       +1     
============================================
+ Hits           1532     1533       +1     
  Misses          295      295              
  Partials        107      107              
Flag Coverage Δ
unittests 79.22% <90.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...omponent/impl/ComponentRewriteRuleServiceImpl.java 83.33% <90.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcd34e9...899deb9. Read the comment docs.

@bstopp bstopp linked an issue Jan 20, 2022 that may be closed by this pull request
@bstopp bstopp merged commit 04d8da3 into adobe:main Jan 20, 2022
@bstopp bstopp deleted the bug/name-error-on-deletion branch January 20, 2022 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository Exception when Rule deletes node
1 participant