Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing builds for Java8. #105

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Fixing builds for Java8. #105

merged 1 commit into from
Jan 11, 2022

Conversation

bstopp
Copy link
Contributor

@bstopp bstopp commented Jan 11, 2022

Related Issue

#104

Motivation and Context

How Has This Been Tested?

Compared outputs and validated bundles start in Java8 AEM Instances.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 11, 2022

Codecov Report

Merging #105 (6b2122a) into main (4d4a058) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #105   +/-   ##
=========================================
  Coverage     79.21%   79.21%           
  Complexity      430      430           
=========================================
  Files            34       34           
  Lines          1934     1934           
  Branches        356      356           
=========================================
  Hits           1532     1532           
  Misses          295      295           
  Partials        107      107           
Flag Coverage Δ
unittests 79.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84fbf03...6b2122a. Read the comment docs.

@bstopp bstopp merged commit 70ae9d4 into adobe:main Jan 11, 2022
@bstopp bstopp deleted the bug/java8-builds branch January 11, 2022 19:01
@bstopp bstopp added the bug Something isn't working label Jan 11, 2022
@bstopp bstopp linked an issue Jan 11, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Java8 AEM65 all package is built for Java11
1 participant