Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circle ci build issues. #330

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Fix circle ci build issues. #330

merged 7 commits into from
Jul 18, 2024

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Jul 15, 2024

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (241831c) to head (0ed998c).

Additional details and impacted files
@@            Coverage Diff            @@
##                dev     #330   +/-   ##
=========================================
  Coverage     77.84%   77.84%           
  Complexity       72       72           
=========================================
  Files             4        4           
  Lines           167      167           
  Branches         31       31           
=========================================
  Hits            130      130           
  Misses           20       20           
  Partials         17       17           
Flag Coverage Δ
unittests 77.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LSantha LSantha requested a review from GiovanniReza July 18, 2024 06:14
@LSantha LSantha merged commit 54ec8a4 into dev Jul 18, 2024
10 checks passed
@LSantha LSantha deleted the fix-build branch July 18, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants