Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SITES-16602 - Remove sort by position option in the Search Results Component #321

Merged
merged 8 commits into from
Nov 8, 2023

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Oct 24, 2023

  • added custom SearchResults model implementation to illustrate the customization of sort fields
  • added unit test
  • updated dependency on CIF components

Description

Related Issue

SITES-16602

Motivation and Context

How Has This Been Tested?

Manually, junit.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

…mponent

 * added custom SearchResults model implementation to illustrate the customization of sort fields
 * added unit test
 * updated dependency on CIF components
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #321 (546b2ee) into dev (75e3770) will decrease coverage by 26.40%.
The diff coverage is 21.87%.

@@              Coverage Diff              @@
##                dev     #321       +/-   ##
=============================================
- Coverage     77.14%   50.74%   -26.40%     
- Complexity       21       25        +4     
=============================================
  Files             1        2        +1     
  Lines            35       67       +32     
  Branches          4        6        +2     
=============================================
+ Hits             27       34        +7     
- Misses            6       30       +24     
- Partials          2        3        +1     
Flag Coverage Δ
unittests 50.74% <21.87%> (-26.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...enia/core/models/commerce/MySearchResultsImpl.java 21.87% <21.87%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@LSantha LSantha merged commit 672317f into dev Nov 8, 2023
@LSantha LSantha deleted the SITES-16602 branch November 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants