fix: remove static templates (fixes #307) #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #313 +/- ##
=========================================
Coverage 77.14% 77.14%
Complexity 21 21
=========================================
Files 1 1
Lines 35 35
Branches 4 4
=========================================
Hits 27 27
Misses 6 6
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
herzog31
approved these changes
Sep 5, 2022
buuhuu
added a commit
that referenced
this pull request
Sep 30, 2022
* CIF-2937 - 2022.08.0 Release Post Actions * set CIF components dependency to snapshot version * fix: Integration Tests failing on datalayer assertions (#314) * releng: update to core cif componetns 2.12.0 * fix: Integration Tests failing on datalayer assertions (#314) * fix: remove old static templates (fixes #307) (#313) Co-authored-by: Levente Santha <levente@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change removes the static templates from /apps/venia/templates. They were not deployed anyway for a while now and we use dynamic templates instead.
Related Issue
#307
Motivation and Context
How Has This Been Tested?
Locally,
mvn testnow works withinui.apps/Screenshots (if appropriate):
Types of changes
Checklist: