Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2842 - Extend List component to list pages by product or category #304

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

LSantha
Copy link
Collaborator

@LSantha LSantha commented Aug 1, 2022

  • added proxy component for commerce list
  • added UI test for commerce list edit dialog

Related Issue

CIF-2842

How Has This Been Tested?

Manually, UI tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

 * added proxy component for commerce list
 * added UI test for commerce list edit dialog
@LSantha
Copy link
Collaborator Author

LSantha commented Aug 1, 2022

The tests will pass after CIF add-on release.

LSantha and others added 2 commits August 3, 2022 16:47
 * replace Core WCM List component proxy with proxy for Commerce List
@buuhuu buuhuu added enhancement New feature or request verified labels Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #304 (1e05932) into dev (970c060) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #304   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            35       35           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            6        6           
  Partials          2        2           
Flag Coverage Δ
unittests 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@LSantha LSantha merged commit 03a7a69 into dev Aug 4, 2022
@LSantha LSantha deleted the CIF-2842 branch August 4, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants