Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2865: remove duplicated datalayer clientlib #301

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jul 8, 2022

Description

With embedding the datalayer clientlib we duplicate the javascript on the page, causing all cmp:clicks to be tracked twice.

This change removes the embed. Now the datalayer clientlib is only loaded async by the page v3 component we use.

Related Issue

CIF-2865

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu marked this pull request as ready for review July 8, 2022 12:58
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #301 (4ebfb44) into dev (b56d17f) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #301   +/-   ##
=========================================
  Coverage     87.09%   87.09%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            31       31           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 87.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b56d17f...4ebfb44. Read the comment docs.

@laurentiumagureanu laurentiumagureanu merged commit d2e3d1d into dev Jul 12, 2022
@laurentiumagureanu laurentiumagureanu deleted the issue/CIF-2865 branch July 12, 2022 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants