Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2895 - Add example for product filter hook #300

Merged
merged 6 commits into from
Jul 13, 2022
Merged

CIF-2895 - Add example for product filter hook #300

merged 6 commits into from
Jul 13, 2022

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Jul 7, 2022

Description

  • Added example of how to extend the product filter via retriever in MyProductTeaser. The added filter does not have any impact when using the Venia product catalog.

Requires a release of adobe/commerce-cif-magento-graphql#29 before it can be merged.

Related Issue

See

How Has This Been Tested?

Manually tested.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added enhancement New feature or request do not merge labels Jul 11, 2022
@herzog31 herzog31 marked this pull request as ready for review July 11, 2022 13:56
@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #300 (c8d66ba) into dev (d2e3d1d) will decrease coverage by 9.95%.
The diff coverage is 0.00%.

❗ Current head c8d66ba differs from pull request most recent head c885f2d. Consider uploading reports for the commit c885f2d to get more accurate results

@@             Coverage Diff              @@
##                dev     #300      +/-   ##
============================================
- Coverage     87.09%   77.14%   -9.96%     
  Complexity       21       21              
============================================
  Files             1        1              
  Lines            31       35       +4     
  Branches          4        4              
============================================
  Hits             27       27              
- Misses            2        6       +4     
  Partials          2        2              
Flag Coverage Δ
unittests 77.14% <0.00%> (-9.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...enia/core/models/commerce/MyProductTeaserImpl.java 77.14% <0.00%> (-9.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e3d1d...c885f2d. Read the comment docs.

@buuhuu buuhuu merged commit b50f7fd into dev Jul 13, 2022
@buuhuu buuhuu deleted the issue/CIF-2895 branch July 13, 2022 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants