Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2827: Add produclist XF example #299

Merged
merged 11 commits into from
Jul 18, 2022
Merged

CIF-2827: Add produclist XF example #299

merged 11 commits into from
Jul 18, 2022

Conversation

laurentiumagureanu
Copy link
Collaborator

Description

Added example usage of XF placeholder in productlist

Related Issue

CIF-2827

Motivation and Context

How Has This Been Tested?

Manually

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@codecov
Copy link

codecov bot commented Jul 6, 2022

Codecov Report

Merging #299 (8e2d819) into dev (2ad1af4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #299   +/-   ##
=========================================
  Coverage     77.14%   77.14%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            35       35           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            6        6           
  Partials          2        2           
Flag Coverage Δ
unittests 77.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ad1af4...8e2d819. Read the comment docs.

@herzog31 herzog31 added the enhancement New feature or request label Jul 7, 2022
<jcr:content
cq:lastModified="{Date}2021-10-11T14:30:58.039+02:00"
cq:lastModifiedBy="admin"
cq:categories="MTQ="
Copy link
Contributor

@buuhuu buuhuu Jul 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category uid is not available in the adobe commerce environment we use for our automated testing. It should be Mzc=

That makes me think, if a ui test would be helpful here.

@buuhuu
Copy link
Contributor

buuhuu commented Jul 13, 2022

This change is missing the policy configuration of the styles for the XF in the product list. When editing the product list this causes the css class to be cleared and the XF appears at the bottom of the list.

@buuhuu buuhuu merged commit 970c060 into dev Jul 18, 2022
@buuhuu buuhuu deleted the issue/CIF-2827 branch July 18, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants