-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIF-2827: Add produclist XF example #299
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #299 +/- ##
=========================================
Coverage 77.14% 77.14%
Complexity 21 21
=========================================
Files 1 1
Lines 35 35
Branches 4 4
=========================================
Hits 27 27
Misses 6 6
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
<jcr:content | ||
cq:lastModified="{Date}2021-10-11T14:30:58.039+02:00" | ||
cq:lastModifiedBy="admin" | ||
cq:categories="MTQ=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The category uid is not available in the adobe commerce environment we use for our automated testing. It should be Mzc=
That makes me think, if a ui test would be helpful here.
This change is missing the policy configuration of the styles for the XF in the product list. When editing the product list this causes the css class to be cleared and the XF appears at the bottom of the list. |
Description
Added example usage of XF placeholder in productlist
Related Issue
CIF-2827
Motivation and Context
How Has This Been Tested?
Manually
Screenshots (if appropriate):
Types of changes
Checklist: