Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2841 - Allow content pages to be associated with products and categories #298

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

herzog31
Copy link
Member

@herzog31 herzog31 commented Jul 4, 2022

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@herzog31 herzog31 added the enhancement New feature or request label Jul 4, 2022
@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #298 (2ac174f) into dev (a258a6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #298   +/-   ##
=========================================
  Coverage     87.09%   87.09%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            31       31           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 87.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a258a6d...2ac174f. Read the comment docs.

@buuhuu buuhuu merged commit b56d17f into dev Jul 11, 2022
@buuhuu buuhuu deleted the issue/CIF-2841 branch July 11, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants