Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2907: add aemanalyzer #291

Merged
merged 4 commits into from
Jul 8, 2022
Merged

CIF-2907: add aemanalyzer #291

merged 4 commits into from
Jul 8, 2022

Conversation

buuhuu
Copy link
Contributor

@buuhuu buuhuu commented Jun 8, 2022

Description

Add the aemanalyzer-maven-plugin to the CS all package. This allows us to verify that the api-region constraints we define in the CIF AddOn are actually applied in the user space.

After the next CIF AddOn release we should set the cif api version property to LATEST to always validate against the latest release of the addon.

Related Issue

CIF-2907

Motivation and Context

We want to be more explicit what projects can and cannot configure. In particular projects should not configure the endpoint / version of the CIF AddOn frontend which will be permitted starting with one of the next CIF AddOn releases.

How Has This Been Tested?

By running maven

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes and the overall coverage did not decrease.
  • All unit tests pass on CircleCi.
  • I ran all tests locally and they pass.

@buuhuu buuhuu added the releng Release Engineering label Jun 8, 2022
@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #291 (49ae456) into dev (a258a6d) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev     #291   +/-   ##
=========================================
  Coverage     87.09%   87.09%           
  Complexity       21       21           
=========================================
  Files             1        1           
  Lines            31       31           
  Branches          4        4           
=========================================
  Hits             27       27           
  Misses            2        2           
  Partials          2        2           
Flag Coverage Δ
unittests 87.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a258a6d...49ae456. Read the comment docs.

@buuhuu buuhuu merged commit 7f0d6f1 into dev Jul 8, 2022
@buuhuu buuhuu deleted the issue/CIF-2907 branch July 8, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
releng Release Engineering verified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants