Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIF-2111 - Add E2E test for product recommendation component #161

Merged
merged 21 commits into from
Jul 30, 2021
Merged

CIF-2111 - Add E2E test for product recommendation component #161

Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c447cfd
CIF-2144 - Add basic extension react component project
herzog31 Jun 22, 2021
f57c625
CIF-2144 - Add support for Apollo client dependency sharing
herzog31 Jun 24, 2021
95c4b98
CIF-2144 - Add PortalPlacer
herzog31 Jun 28, 2021
8e221e4
CIF-2143: Add product recs to Venia
laurentiumagureanu Jun 30, 2021
a5f84e8
CIF-2143: Fix dependencies
laurentiumagureanu Jun 30, 2021
6e1af5a
Merge branch 'dev' into issues/CIF-2143
laurentiumagureanu Jun 30, 2021
23f1be7
Merge branch 'dev' of github.com:adobe/aem-cif-guides-venia into issu…
herzog31 Jun 30, 2021
12ae1f4
CIF-2144 - Add todo
herzog31 Jun 30, 2021
a95d9c0
CIF-2143: Fix dependencies in all package
laurentiumagureanu Jul 1, 2021
470f173
Merge branch 'dev' into issues/CIF-2143
laurentiumagureanu Jul 1, 2021
9c4721e
Merge branch 'dev' of github.com:adobe/aem-cif-guides-venia into issu…
herzog31 Jul 1, 2021
7cd7729
Merge branch 'issues/CIF-2143' of github.com:adobe/aem-cif-guides-ven…
herzog31 Jul 1, 2021
e43b9df
CIF-2144 - Update i18n config
herzog31 Jul 2, 2021
ef7be7e
Merge branch 'dev' into issues/CIF-2143
buuhuu Jul 8, 2021
d8e5893
CIF-2144 - Add feedback
herzog31 Jul 8, 2021
a4dffb4
Merge branch 'issues/CIF-2143' of github.com:adobe/aem-cif-guides-ven…
herzog31 Jul 8, 2021
08e50fc
Merge branch 'dev' of github.com:adobe/aem-cif-guides-venia into issu…
herzog31 Jul 8, 2021
5f751dd
Merge branch 'dev' into issue/CIF-2144
buuhuu Jul 14, 2021
b0598b0
CIF-2111 - Add E2E test for product recommendation component
herzog31 Jul 15, 2021
c642db0
Merge branch 'dev' of github.com:adobe/aem-cif-guides-venia into issu…
herzog31 Jul 26, 2021
2e4b45a
Merge branch 'dev' into issue/CIF-2111
herzog31 Jul 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ common:
mvn -B clean install
cd react-components
npm link
cd ../extensions/product-recs/react-components
npm link
fi
working_directory: ./dependencies

Expand Down
2 changes: 1 addition & 1 deletion ui.frontend/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ Since Venia is acting like a consumer for `aem-core-cif-react-components` you ma

As a prerequisite, you need to have `node` and `npm` installed before you perform any of the steps below:

1. Go to the `aem-core-cif-react-components/react-components` and use the following commands:
1. In the CIF Core Components project, go to `react-components/react-components` and `extensions/product-recs/react-components` and use the following commands:

```bash
npm run webpack:dev
Expand Down
205 changes: 56 additions & 149 deletions ui.frontend/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions ui.frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@
"prod": "webpack -p --config ./webpack.prod.js && clientlib --verbose",
"start": "webpack-dev-server --open --config ./webpack.dev.js",
"prettier:check": "prettier --check '{src,test}/**/*.{js,css}' --config ./.prettierrc",
"prettier:fix": "prettier --write '{src,test}/**/*.{js,css}' --config ./.prettierrc"
"prettier:fix": "prettier --write '{src,test}/**/*.{js,css}' --config ./.prettierrc",
"eslint:check": "eslint 'src/**/*.js'",
"eslint:fix": "eslint --fix 'src/**/*.js'"
},
"devDependencies": {
"@babel/core": "^7.10.4",
Expand All @@ -36,7 +38,6 @@
"css-loader": "^3.0.0",
"cssnano": "^4.1.10",
"eslint": "^6.8.0",
"eslint-loader": "^3.0.3",
"eslint-plugin-header": "^3.0.0",
"eslint-plugin-jest": "^23.18.0",
"eslint-plugin-react": "^7.20.3",
Expand All @@ -63,6 +64,7 @@
},
"dependencies": {
"@adobe/aem-core-cif-react-components": "^1.12.0",
"@apollo/client": "^3.2.4",
"i18next": "^19.5.3",
"i18next-browser-languagedetector": "^5.0.0",
"i18next-xhr-backend": "^3.2.2",
Expand Down
18 changes: 2 additions & 16 deletions ui.frontend/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,6 @@
<build>
<sourceDirectory>src/main/content/jcr_root</sourceDirectory>
<plugins>
<plugin>
<groupId>com.github.eirslett</groupId>
<artifactId>frontend-maven-plugin</artifactId>
<executions>
<execution>
<id>npm run prod</id>
<phase>generate-resources</phase>
<goals>
<goal>npm</goal>
</goals>
<configuration>
<arguments>run prod</arguments>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-assembly-plugin</artifactId>
Expand Down Expand Up @@ -146,6 +130,7 @@
<arguments>
<argument>link</argument>
<argument>@adobe/aem-core-cif-react-components</argument>
<argument>@adobe/cif-product-recs-extension</argument>
</arguments>
</configuration>
</execution>
Expand Down Expand Up @@ -192,6 +177,7 @@
<argument>install</argument>
<argument>-S</argument>
<argument>@adobe/aem-core-cif-react-components@${core.cif.components.version}</argument>
<argument>@adobe/cif-product-recs-extension@${core.cif.components.version}</argument>
</arguments>
</configuration>
</execution>
Expand Down
Loading