CIF-1907 - Build navigation component based on WCM Core Component #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implemented Venia theme for navigation component v2
* fix test failures
Codecov Report
@@ Coverage Diff @@
## dev #126 +/- ##
=========================================
Coverage 85.71% 85.71%
Complexity 18 18
=========================================
Files 1 1
Lines 28 28
Branches 4 4
=========================================
Hits 24 24
Misses 2 2
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
dplaton
approved these changes
Apr 19, 2021
Merged
mhaack
added a commit
that referenced
this pull request
Apr 22, 2021
* @releng - update CIF Core Components dependency to SNAPSHOT version * CIF-1718 - Adopt Magento GraphQL schema changes - Category UID - update graphql dependency to 2.4.2 EE to align with CIF components * CIF-2015 - Migrate to Azul Zulu JDK (#125) * @trivial fix ui.frontend readme (#128) * CIF-2039 - Missing root category field in catalog page properties (#127) * CIF-2039 - Missing root category field in catalog page properties * added UI test for catalog page properties extensions * CIF-2039 - Missing root category field in catalog page properties * added UI test for catalog page properties extensions * CIF-2039 - Missing root category field in catalog page properties * fixed root category field label in UI test * CIF-1907 - Build navigation component based on WCM Core Component (#126) * CIF-1907 - Build navigation component based on WCM Core Component * implemented Venia theme for navigation component v2 * CIF-1907 - Build navigation component based on WCM Core Component * fix test failures Co-authored-by: Markus Haack <mhaack@adobe.com> * @trivial - update dependencies (#129) Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com>
dplaton
added a commit
that referenced
this pull request
May 24, 2021
* @releng - update CIF Core Components dependency to SNAPSHOT version * CIF-1718 - Adopt Magento GraphQL schema changes - Category UID - update graphql dependency to 2.4.2 EE to align with CIF components * CIF-2015 - Migrate to Azul Zulu JDK (#125) * @trivial fix ui.frontend readme (#128) * CIF-2039 - Missing root category field in catalog page properties (#127) * CIF-2039 - Missing root category field in catalog page properties * added UI test for catalog page properties extensions * CIF-2039 - Missing root category field in catalog page properties * added UI test for catalog page properties extensions * CIF-2039 - Missing root category field in catalog page properties * fixed root category field label in UI test * CIF-1907 - Build navigation component based on WCM Core Component (#126) * CIF-1907 - Build navigation component based on WCM Core Component * implemented Venia theme for navigation component v2 * CIF-1907 - Build navigation component based on WCM Core Component * fix test failures Co-authored-by: Markus Haack <mhaack@adobe.com> * @trivial - update dependencies (#129) * CIF-1746 - Create CIF data types for Content Fragment Models (#102) * enable content fragment models in Venia configuration * CIF-2007 - Use latest releases of CIF Add-on for IT and UI tests (#132) * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on from artifactory * CIF-2007 - Use latest release of CIF add-on for AEM 6.5 from artifactory * CIF-2007 - Fix UI tests * @releng Update dependency versions (#134) Update `AEM Core CIF Components` to 1.11.0 and `@adobe/aem-core-cif-react-components` to 1.11.0 Co-authored-by: Daniel Platon <platon@adobe.com> * CIF-2086: Update react-components to be in sync with CIF Components version (#133) * CIF-2086: Sync reac-components version on release * CIF-2086: Commit updated npm files * CIF-2086: Fix npm files commit profile * CIF-2086: Update cif-react-components dependency * Remove package-lock.json from .gitignore Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Levente Santha <levente@adobe.com> Co-authored-by: Christophe Jelger <jelger@adobe.com> Co-authored-by: Mark J. Becker <herzog31@users.noreply.github.com> Co-authored-by: Markus Haack <mhaack@adobe.com> Co-authored-by: Daniel Platon <platon@adobe.com> Co-authored-by: Laurentiu Magureanu <magurean@adobe.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
CIF-1907
How Has This Been Tested?
Manually.
Screenshots (if appropriate):
Types of changes
Checklist: