Skip to content

Commit

Permalink
CIF-2086: Update react-components to be in sync with CIF Components v…
Browse files Browse the repository at this point in the history
…ersion (#133)

* CIF-2086: Sync reac-components version on release

* CIF-2086: Commit updated npm files

* CIF-2086: Fix npm files commit profile

* CIF-2086: Update cif-react-components dependency

* Remove package-lock.json from .gitignore

Co-authored-by: Daniel Platon <platon@adobe.com>
  • Loading branch information
laurentiumagureanu and Daniel Platon authored May 24, 2021
1 parent fe6e43d commit 143b2b8
Show file tree
Hide file tree
Showing 3 changed files with 55 additions and 3 deletions.
1 change: 0 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ buildNumber.properties

# NPM
node_modules/
package-lock.json
yarn.lock

# Webpack
Expand Down
23 changes: 22 additions & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<version>2.5.3</version>
<configuration>
<scmCommentPrefix>[maven-scm] :</scmCommentPrefix>
<preparationGoals>clean install</preparationGoals>
<preparationGoals>-Pcommit-changed-npm-files clean install scm:add scm:checkin</preparationGoals>
<goals>install</goals>
<releaseProfiles>release</releaseProfiles>
<autoVersionSubmodules>true</autoVersionSubmodules>
Expand Down Expand Up @@ -601,6 +601,27 @@ Bundle-DocURL:
</pluginManagement>
</build>
</profile>
<profile>
<id>commit-changed-npm-files</id>
<activation>
<activeByDefault>false</activeByDefault>
</activation>
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-scm-plugin</artifactId>
<configuration>
<includes>ui.frontend/package.json,ui.frontend/package-lock.json</includes>
<message>[maven-release-plugin] :update react-components version to ${core.cif.components.version}</message>
<pushChanges>false</pushChanges>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>
</profile>
</profiles>


Expand Down
34 changes: 33 additions & 1 deletion ui.frontend/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
</execution>
</executions>
</plugin>

</plugins>
</build>

Expand Down Expand Up @@ -168,6 +168,38 @@
</plugins>
</build>
</profile>
<profile>
<id>release-prepare</id>
<activation>
<activeByDefault>false</activeByDefault>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>exec-maven-plugin</artifactId>
<version>3.0.0</version>
<executions>
<execution>
<id>react-components-install</id>
<phase>generate-resources</phase>
<goals>
<goal>exec</goal>
</goals>
<configuration>
<executable>npm</executable>
<arguments>
<argument>install</argument>
<argument>-S</argument>
<argument>@adobe/aem-core-cif-react-components@${core.cif.components.version}</argument>
</arguments>
</configuration>
</execution>
</executions>
</plugin>
</plugins>
</build>
</profile>
</profiles>

</project>

0 comments on commit 143b2b8

Please sign in to comment.