Correctly detect EOL in chunked uploads #1837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d749826 to
8c93717
Compare
Even though the AWS documentation says that they always use "CRLF" as the EOL indicator, it seems to depend on the system when using async (native) clients. Now, we use a BufferedReader to correctly detect and read full lines where we need to. MultiPartUploadV2IT#testMultipartUpload_asyncClient failed when using a file >16KB before this fix, now it is successful. Fixes #1818
8c93717 to
dc01aff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Even though the AWS documentation says that they always use "CRLF" as the EOL indicator, it seems to depend on the system when using async (native) clients.
Now, we use a BufferedReader to correctly detect and read full lines where we need to.
MultiPartUploadV2IT#testMultipartUpload_asyncClientfailed when using a file >16KB before this fix, now it is successful.Related Issue
Fixes #1818
Tasks