Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change length of data type Identifier from 2000 to 2048 Char #306

Closed
BirgitBoss opened this issue Nov 19, 2023 · 2 comments
Closed

Change length of data type Identifier from 2000 to 2048 Char #306

BirgitBoss opened this issue Nov 19, 2023 · 2 comments
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Milestone
V3.1

Comments

@BirgitBoss
Copy link
Collaborator

BirgitBoss commented Nov 19, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Change length of data type Identifier from 2000 to 2024 Char (Correction: 2048)
@BirgitBoss BirgitBoss added accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally labels Nov 19, 2023
@BirgitBoss BirgitBoss added this to the V3.1 milestone Nov 19, 2023
@BirgitBoss
Copy link
Collaborator Author

decision 25th Oct. 2023 in Workstream AAS of IDTA: accepted

@BirgitBoss BirgitBoss mentioned this issue Dec 15, 2023
Closed
@BirgitBoss BirgitBoss linked a pull request Dec 15, 2023 that will close this issue
Resolve issues, focus specification/schemata #315
Closed
@BirgitBoss BirgitBoss mentioned this issue Dec 21, 2023
Merged
@BirgitBoss
Copy link
Collaborator Author

It should be 2048, not 2024.

@BirgitBoss BirgitBoss reopened this Mar 7, 2024
@BirgitBoss BirgitBoss changed the title Change length of data type Identifier from 2000 to 2024 Char Change length of data type Identifier from 2000 to 2048 Char Mar 7, 2024
BirgitBoss added a commit that referenced this issue Mar 7, 2024
@BirgitBoss
closes #306, bugfix 2024 ==> 2048
fb8f9af
@BirgitBoss BirgitBoss mentioned this issue Mar 7, 2024
Merged
g1zzm0 pushed a commit that referenced this issue Mar 13, 2024
@BirgitBoss
closes #306, bugfix 2024 ==> 2048 (#374)
02180d0 
Change length restriction to 2048
BirgitBoss added a commit to admin-shell-io/aas-specs-api that referenced this issue Apr 8, 2024
@BirgitBoss
Data Type Identifier changed in Part 1
f97ccd1 
(see admin-shell-io/aas-specs#306)
from 2000 to 2024 charactery
This was referenced Apr 8, 2024
Merged
Merged
s-heppner added a commit to aas-core-works/aas-core-meta that referenced this issue Oct 8, 2024
@s-heppner
V3.1: Adapt Identifier length to 2048
9e7bb4a 
Previously, the invariant declaring the maximum
length of `Identifier` was set to `2000`. We had
already adapted this to `2024` according to
[aas-specs#306], however the specification was
corrected to `2048` in [aas-specs#306].

We therefore adapt the invariant to a maximum
length of `2048`

[aas-specs#306](admin-shell-io/aas-specs#306)
@s-heppner s-heppner mentioned this issue Oct 8, 2024
Merged
s-heppner added a commit to aas-core-works/aas-core-meta that referenced this issue Oct 8, 2024
@s-heppner
V3.1: Adapt Value_type_IEC_61360 length to 2048
739a2ef 
Previously, the invariant declaring the maximum
length of `Value_type_IEC_61360` was set to
`2000`. Decided in [aas-specs#306] and specified
in [aas-specs-iec61360#21] this was adapted to
`2048`.

We therefore adapt the invariant to a maximum
length of `2048`

[aas-specs#306](admin-shell-io/aas-specs#306)
[aas-specs-iec61360#21](admin-shell-io/aas-specs-iec61360#21)
s-heppner added a commit to aas-core-works/aas-core-meta that referenced this issue Oct 18, 2024
@s-heppner
V3.1: Adapt Identifier length to 2048
c9ff3bf 
Previously, the invariant declaring the maximum
length of `Identifier` was set to `2000`. We had
already adapted this to `2024` according to
[aas-specs#306], however the specification was
corrected to `2048` in [aas-specs#306].

We therefore adapt the invariant to a maximum
length of `2048`

[aas-specs#306](admin-shell-io/aas-specs#306)
s-heppner added a commit to aas-core-works/aas-core-meta that referenced this issue Oct 18, 2024
@s-heppner
V3.1: Adapt Value_type_IEC_61360 length to 2048
34ea6b4 
Previously, the invariant declaring the maximum
length of `Value_type_IEC_61360` was set to
`2000`. Decided in [aas-specs#306] and specified
in [aas-specs-iec61360#21] this was adapted to
`2048`.

We therefore adapt the invariant to a maximum
length of `2048`

[aas-specs#306](admin-shell-io/aas-specs#306)
[aas-specs-iec61360#21](admin-shell-io/aas-specs-iec61360#21)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted accepted in principle to be fixed specification impact on specification and thus on xml, json etc., label "aas-core" not set additinally
Projects
None yet
Milestone
V3.1
Development

Successfully merging a pull request may close this issue.

Resolve issues, focus specification/schemata admin-shell-io/aas-specs
1 participant
@BirgitBoss