fix: Prevent crash when using waitOn in Windows #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While Windows understands the command `./node_modules/.bin/wait-on` when run isolated, at the moment it is not working when using concurrently. `npx wait-on` works fine and ensures the module can be run even if it was previously deleted for some reason.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Misty is crashing in Windows when using the waitOn option (see https://github.com/Automattic/simplenote-electron/issues/1601). This is due to
concurrentlysomehow messing the command./node_modules/.bin/wait-on, which works fine when run in isolation from the command prompt.npx wait-onis a good alternative that prevents the crash and ensures thewait-oncan be run even if it was previously deleted for any reason.