addressing comments

Signed-off-by: Adi Suissa-Peleg <adip@google.com>
adisuissa · Sep 20, 2024 · 3e3dd02 · 3e3dd02
1 parent 2f66c7b
commit 3e3dd02
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/source/extensions/config_subscription/grpc/xds_mux/grpc_mux_impl.h b/source/extensions/config_subscription/grpc/xds_mux/grpc_mux_impl.h
@@ -172,7 +172,7 @@ class GrpcMuxImpl : public GrpcStreamCallbacks<RS>,
   }
   const LocalInfo::LocalInfo& localInfo() const { return local_info_; }
 
-  virtual std::string methodName() const PURE;
+  virtual absl::string_view methodName() const PURE;
 
 private:
   // Helper function to create the grpc_stream_ object.
@@ -262,7 +262,7 @@ class GrpcMuxDelta : public GrpcMuxImpl<DeltaSubscriptionState, DeltaSubscriptio
                              const absl::flat_hash_set<std::string>& for_update) override;
 
 private:
-  std::string methodName() const override {
+  absl::string_view methodName() const override {
     return "envoy.service.discovery.v3.AggregatedDiscoveryService.DeltaAggregatedResources";
   }
 };
@@ -279,7 +279,7 @@ class GrpcMuxSotw : public GrpcMuxImpl<SotwSubscriptionState, SotwSubscriptionSt
   }
 
 private:
-  std::string methodName() const override {
+  absl::string_view methodName() const override {
     return "envoy.service.discovery.v3.AggregatedDiscoveryService.StreamAggregatedResources";
   }
 };