Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to LTS 5 #9

Merged
merged 1 commit into from
Feb 1, 2016
Merged

upgrade to LTS 5 #9

merged 1 commit into from
Feb 1, 2016

Conversation

srijs
Copy link
Collaborator

@srijs srijs commented Feb 1, 2016

Upgrades to Stackage LTS 5.

More specifically, migrates from retry 0.6.x to 0.7.x, which changed Int to RetryStatus. Since the OneForOne constructor is exposed, this will be a breaking change for this library.

@adinapoli
Copy link
Owner

Nice one!

I would like to keep this one pending until I do not release 1.0.4.1, and at that point I will roll out 1.1.0.0 to indicate the breaking change. The changelog would be updated to reflect that.

Incidentally, I think it might be beneficial some day to also bump the stack version travis is using as it's quite old:

https://github.com/adinapoli/threads-supervisor/blob/master/.travis.yml#L16

@srijs
Copy link
Collaborator Author

srijs commented Feb 1, 2016

Sounds good! Would there be interest from your side to get the library into Stackage to make sure that it keeps being compatible with future releases?

@adinapoli
Copy link
Owner

@srijs I'm definitely not opposed in having it! I have already mandrill on Stackage. I didn't put this one as nobody asked me about 😉

@srijs
Copy link
Collaborator Author

srijs commented Feb 1, 2016

@adinapoli If it's not a nuisance to you, I'd certainly appreciate it.

As soon as this PR is merged, I'd probably start to work on a OneForAll strategy, if that's okay with you.

@adinapoli
Copy link
Owner

@srijs Totally fine by me! I will add a couple of extra tickets in the issue tracker to reflect what we want (release on Stackage and OneForAll strategy) and I will assign the latter to you.

Also, in case I forget, remind me to add you to the list of Contributors 😉

adinapoli added a commit that referenced this pull request Feb 1, 2016
@adinapoli adinapoli merged commit 57ac5ca into adinapoli:master Feb 1, 2016
@srijs srijs deleted the fix/stack-lts-5 branch February 1, 2016 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants