Add option to specify order of taps #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KetanReddy
commented
Dec 5, 2022
| @@ -214,6 +220,17 @@ abstract class Hook< | |||
| }; | |||
|
|
|||
| this.taps.push(tap); | |||
| this.taps.sort((A, B) => { | |||
There was a problem hiding this comment.
Have to sort it here because the new tap being added could be in the before of a previous tap. So all taps need to be reevaluated.
adierkens
reviewed
Dec 6, 2022
src/hooks.test.ts
Outdated
| syncHook.tap("tap1", (input) => { | ||
| return [...input, 'tap1'] | ||
| }); | ||
| syncHook.tap({name: "tap2", before: "tap1"}, (input) => { |
There was a problem hiding this comment.
Can you add a test here for the array variant too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a parameter
beforeto specify which, if any, taps the new tap should be called before. This API exists in the original webpack implementation so this should bring it a bit more inline with it's API.