Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Create/update entity send log columns. #612

Conversation

EdwinBetanc0urt
Copy link
Collaborator

Bug report

Currently the columns, used for the log record, are being sent to the server from the client, these columns should be omitted as they should be handled by the server only.

Steps to reproduce

Currently the columns, used for the log record, are being sent to the server from the client, these columns should be omitted as they should be handled by the server only.

  1. Expand the System Admin menu.
  2. Open Issue Report window.
  3. Run action New Record and fill fields.

Screenshot or Gif

After this PR:
issue-report-error

Before this PR:
issue-report-fix

Expected behavior

These columns should always remain read-only for both log entry and editing, as they are in the smart browser results and window.
As for the smart browser and query criteria reports/processes and forms, they can be editable (if defined in the application dictionary) since they do not modify record data from the client but are used for queries.

Other relevant information

  • Your OS: Linux Mint 19.1 Cinnamon x64.
  • Web Browser: Mozilla Firefox 85.0.
  • Node.js version: 12.20.0.
  • adempiere-vue version: 4.3.1.

Additional context

the evaluation of obligatory nature is omitted and the t fields are placed as read-only are placed where applicable.

@yamelsenih yamelsenih merged commit 0405066 into adempiere:develop Feb 27, 2021
@EdwinBetanc0urt EdwinBetanc0urt deleted the bugfix/send-log-columns-create-and-update-entity branch March 3, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants