Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Required to complete" feature #549

Closed
wants to merge 1 commit into from
Closed

"Required to complete" feature #549

wants to merge 1 commit into from

Conversation

LukaszGrela
Copy link
Contributor

This adds ability to specify which components should be completed to mark entire block (and other components) as completed. Block model needs to specify _requireCompletionOf property which can have following values: 'all', 'any' or valid component id that is child of this block e.g. c-02. Below are few examples of use. When _requireCompletionOf is missing or empty it defaults to all.

{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": "any"
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": ["all"]
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": "c-05"
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": ["c-05","c-10"]
},

This adds ability to specify which components should be completed to mark entire block (and other components) as completed. Block model needs to specify _requireCompletionOf property which can have following values: 'all', 'any' or valid component id that is child of this block. Below are few examples of use. When _requireCompletionOf is missing or empty it defaults to all.

{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": "any"
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": ["all"]
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": "c-05"
},
{
    "_id": "b-03",
    "_parentId": "a-02",
    "_type": "block",
    "_requireCompletionOf": ["c-05","c-10"]
},
@brian-learningpool
Copy link
Member

Lukasz, there has been some discussion around the area of what counts towards completion in issue #490.

I think that a better approach might be for components to say whether or not they require completion to be counted as part of the course completion.

@LukaszGrela
Copy link
Contributor Author

Maybe, but this way I found it less invasive, it will work with previous and future sources.

@taylortom taylortom added this to the Backlog milestone Mar 17, 2015
@oliverfoster
Copy link
Member

Note: Current isOptional proposals do not provide Lukasz 'any' functionality which could be quite useful.

@taylortom
Copy link
Member

Can see the use for the completion of any - will park this for when we tackle the _isOptional implementation

@moloko
Copy link
Contributor

moloko commented Jun 3, 2015

@LukaszGrela - as we mentioned we have been working on implementing the _isOptional feature properly (which is now done). This clearly duplicates some of what you've done here - though not the 'any' feature. However, we really like this idea and so have logged ticket ABU-673 in Jira for it as a likely future development item

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants